Fixed GitHub Actions failing jobs#601
Open
piyushkdas0611 wants to merge 3 commits intoRoshansuthar1105:mainfrom
Open
Fixed GitHub Actions failing jobs#601piyushkdas0611 wants to merge 3 commits intoRoshansuthar1105:mainfrom
piyushkdas0611 wants to merge 3 commits intoRoshansuthar1105:mainfrom
Conversation
👷 Deploy request for codifylearn pending review.Visit the deploys page to approve it
|
Thanks for creating a PR for your Issue!
|
Author
|
Kindly do a thorough testing before merging to main and put the "hacktoberfest-accepted" label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI/CD Pipeline Build Failures
Overview
This PR addresses critical build failures in the CI/CD pipeline by fixing import path issues and making OAuth configurations optional for development environments.
Issues Fixed
The CI/CD pipeline was failing due to:
Changes Made
Commit 1: Fix NodeJS Fundamentals Import Path Case Sensitivity
File:
client/src/App.jsxNodeJsFundamentalsvs actual directoryNodeJSFundamentals"./pages/Notes/NodeJsFundamentals/NodeJsFundamentals.jsx"to"./pages/Notes/NodeJSFundamentals/NodeJSFundamentals.jsx"Commit 2: Fix PasswordStrength Component Import Path
File:
client/src/pages/Signup.jsx"../../components/PasswordStrength"to"../components/PasswordStrength"Commit 3: Make OAuth Strategies Optional for Development
File:
server/config/passport.jsGOOGLE_CLIENT_ID,GOOGLE_CLIENT_SECRET, andGOOGLE_LOGIN_CALLBACK_URLare presentGOOGLE_CLIENT_ID,GOOGLE_CLIENT_SECRET, andGOOGLE_SIGNUP_CALLBACK_URLare presentGITHUB_CLIENT_ID,GITHUB_CLIENT_SECRET, andGITHUB_LOGIN_CALLBACK_URLare presentTechnical Details
Build Errors Resolved
Server Startup Error Resolved
Testing
Environment Compatibility
Files Modified
client/src/App.jsx- Fixed NodeJS fundamentals import casingclient/src/pages/Signup.jsx- Fixed PasswordStrength import pathserver/config/passport.js- Made OAuth strategies conditionalBreaking Changes
None. All changes are backward compatible and non-breaking.
Notes for Reviewers